Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the missing null values in the output #317

Merged
merged 3 commits into from
May 12, 2023
Merged

Fixes the missing null values in the output #317

merged 3 commits into from
May 12, 2023

Conversation

semihbkgr
Copy link
Contributor

fixes #316

@semihbkgr semihbkgr changed the title set nil value to the map when the value is invalid Fixes the missing 'null' values in the output May 6, 2023
@semihbkgr semihbkgr changed the title Fixes the missing 'null' values in the output Fixes the missing null values in the output May 6, 2023
@TomWright
Copy link
Owner

The change looks good - could I ask you to add a test for this please? Just the example you gave in the original issue would be good enough.

You can add a top level test here:

dasel/internal/command/select_test.go

Line 41 in 3b466e8

func TestSelectCommand(t *testing.T) {

TomWright
TomWright requested changes May 8, 2023
View reviewed changes
Copy link
Owner

@TomWright TomWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look at the failing test tomorrow

@semihbkgr
Copy link
Contributor Author

Tests started failing after Ordered maps #289 merge.

@semihbkgr
Copy link
Contributor Author

I slightly debugged to find out which changes cause to fail. Seems like It is the same reason as #296.

@TomWright
Copy link
Owner

OK thanks - I'll take a look to see what I broke with that PR and merge this when resolved 👍

@TomWright
Copy link
Owner

Hey @semihbkgr, sorry for the delay.

I've fixed the issue - the root cause was a new data structure being used to allow for ordered maps. I just had to replicate the same logic in another place.

Thanks for the contribution!

@TomWright TomWright merged commit 52b5934 into TomWright:master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomWright TomWright TomWright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The fields with null value just disappear in the output
2 participants
@semihbkgr @TomWright